Changeset 17729 for ext

Timestamp:

09/09/07 13:00:05 (16 months ago)

Author:

masak

Message:

[ext/File-Util/lib/File/Util.pm]
* $cond ?? $var = 1 !! $var = undef; has the wrong priorities
* better written as $var = ?($cond) anyway
* nicer error messages

Files:

• ext/File-Util/lib/File/Util.pm (modified) (3 diffs)

ext/File-Util/lib/File/Util.pm

@@ -223 +223 @@
 
 method existent (Str $filename) {
-    $filename ~~ :e ?? $.exist = 1 !! $.exist = undef;
+    $.exist = ?($filename ~~ :e);
 }
 
 method valid_filename (Str $filename){
-    if $filename ~~ /<illegal_chr>/ {
-        $.valid = undef;
-    } else {
-        $.valid = 1;
-    }
+    $.valid = !($filename ~~ /<illegal_chr>/);
 }
 
@@ -247 +243 @@
 
 method can_read (Str $filename) {
-    $filename ~~ :r ?? $.canread = 1 !! $.canread = undef;
+    $.canread = ?($filename ~~ :r);
 }
 
 method can_write (Str $filename) {
-    $filename ~~ :w ?? $.canwrite = 1 !! $.canwrite = undef;
+    $.canwrite = ?($filename ~~ :w);
 }
 
 method is_bin (Str $filename) {
-    $filename ~~ :B ?? $.isbin = 1 !! $.isbin = undef;
+    $.isbin = ?($filename ~~ :B);
 }
 
@@ -280 +276 @@
 
 method throw (Str $call, $meth?, $filename?, $opts?, $missing?) {
-    say $call ~ $filename;
+    say [$call, $filename].join(': ');
 }